create rays on device when rendering #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it depends on utilization/hardware... I got no speed up when running render on a server by itself. But when running 8 copies in parallel on the server (1 per gpu), the cpu became the bottleneck and I got 10x speedup after. |
|
Feel free to merge |
I don't have merge access. |
I merged for now. Sent you a new invite. |
tancik
pushed a commit
to dozeri83/nerfstudio
that referenced
this pull request
Jan 20, 2023
Co-authored-by: zmurez <[email protected]>
chris838
pushed a commit
to chris838/nerfstudio
that referenced
this pull request
Apr 22, 2023
Co-authored-by: zmurez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
traj=="filename"camera_ray_bundleis generated on the cpu and then moved to the gpu which can be slow.