Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo error which should be self.cameras.times #991

Merged
merged 1 commit into from
Nov 21, 2022
Merged

fix typo error which should be self.cameras.times #991

merged 1 commit into from
Nov 21, 2022

Conversation

ksnzh
Copy link
Contributor

@ksnzh ksnzh commented Nov 21, 2022

No description provided.

@ksnzh
Copy link
Contributor Author

ksnzh commented Nov 21, 2022

The old code will cause attribute error that 'Cameras' object has no attribute 'time'.

tancik
tancik approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@tancik tancik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@tancik tancik merged commit d767cd5 into nerfstudio-project:main Nov 21, 2022
This was referenced Nov 21, 2022
Closed
Closed
chris838 pushed a commit to chris838/nerfstudio that referenced this pull request Apr 22, 2023
@ksnzh
fix typo error which should be self.cameras.times (nerfstudio-project…
f42a5a4 
…#991)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tancik tancik tancik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ksnzh @tancik