Support downsample in dataset #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tancik
reviewed
Nov 17, 2022
| @@ -266,6 +266,10 @@ class VanillaDataManagerConfig(InstantiateConfig): | |||
| camera_optimizer: CameraOptimizerConfig = CameraOptimizerConfig() | |||
| """Specifies the camera pose optimizer used during training. Helpful if poses are noisy, such as for data from | |||
| Record3D.""" | |||
| dataset_camera_scale_factor: float = 1.0 | |||
There was a problem hiding this comment.
Maybe camera_res_scale_factor. I worry this may be ambiguous with extrinsic scale.
tancik
reviewed
Nov 17, 2022
Fair enough. Agree - it is probably a judgement call on which of the above methods are appropriate. Let me know if you agree that this feature in additional also makes sense |
tancik
approved these changes
Nov 18, 2022
chris838
pushed a commit
to chris838/nerfstudio
that referenced
this pull request
Apr 22, 2023
* init * tests passing * pass through arguments * verbose * remove debug prints * switch to bilinear * update viewer * make parser outputs private * change name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed briefly in #957 - it seems like have downsample support in the base InputDataset could be beneficial. While colmap outputs images at multiple-resolutions this may not be the case for many other applications where there are images only stored at a single resolution. This allows us to load in data in the raw format and downsample once loaded to disk