Updating the script for downloading data #968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanweber
reviewed
Nov 16, 2022
tancik
reviewed
Nov 23, 2022
brentyi
reviewed
Nov 25, 2022
ethanweber
reviewed
Nov 26, 2022
There was a problem hiding this comment.
Looking better, but there are a lot of docs that need to updated still. For example, commands like ns-download-data --dataset=nerfstudio --capture=poster. Also looks like you renamed --capture to --capture-name, which will have to be updated in the docs as well. I'm okay with the new name since it's more verbose.
ethanweber
approved these changes
Nov 26, 2022
tancik
pushed a commit
to dozeri83/nerfstudio
that referenced
this pull request
Jan 20, 2023
* Updating the script for downloading data * Making update to config structure * Updating documentation and colab * Adding back the save directory * Pushing an all flag for nerfstudio * forgot to save some previous edits
chris838
pushed a commit
to chris838/nerfstudio
that referenced
this pull request
Apr 22, 2023
* Updating the script for downloading data * Making update to config structure * Updating documentation and colab * Adding back the save directory * Pushing an all flag for nerfstudio * forgot to save some previous edits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.