Support exporting point clouds #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanweber
approved these changes
Nov 9, 2022
|
|
||
| def generate_point_cloud( | ||
| pipeline: Pipeline, | ||
| num_points: int = 1000000, |
There was a problem hiding this comment.
1e6 is a float, not an int. I can add the typecast, but at that point it seems a bit excessive.
| class ExportPointCloud(Exporter): | ||
| """Class to export meshes with the poisson algorithm.""" | ||
|
|
||
| num_points: int = 1000000 |
chris838
pushed a commit
to chris838/nerfstudio
that referenced
this pull request
Apr 22, 2023
* Support exporting point clouds * Fix typing * lint * Update requirements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pointclouds can now be exported from a trained nerf.
ns-export pointcloud --load-config CONFIG --output-dir DIR