-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Computing and predicting normals #905
Merged
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
7a06e40
staring normals PR
ethanweber c767eff
code runs but visualization looks bad
ethanweber 94b3124
Camera and world coordinate conventions (#889)
ethanweber f2d3525
Start viewer with more accurate speed calculation (#899)
tancik 46a661f
Minor doc updates (#903)
tancik 99053a1
fix conflicts
ethanweber 528807b
code runs but visualization looks bad
ethanweber 3c8d425
normals implemented and vis fixed. still debugging quality
ethanweber 0be1fc5
minor name change
ethanweber 62b20bd
comment
ethanweber 89a2c94
Merge branch 'main' into ethan/adding_normals
ethanweber 2b53638
fix black
ethanweber 8a5e434
lint
ethanweber 20e9734
predicting normals
ethanweber be83a2e
adding detach
ethanweber b7667f7
predicted normals
ethanweber 4360411
Merge branch 'main' of https://github.com/plenoptix/nerfactory into e…
terrancewang a9d8ab0
improved normals prediction performance
terrancewang 97601a8
Merge branch 'main' of https://github.com/plenoptix/nerfactory into e…
terrancewang 71e0b46
cleaning code
terrancewang c2fb388
cleaning code
terrancewang a09e924
cleaning code
terrancewang 7cacc47
adding type to function param
terrancewang c5bd54c
fixing tensorf forward func
terrancewang 1970493
reverting tensorf changes
terrancewang 432dcfc
fix style with tensorf field
terrancewang 55e0ef5
adding normals check to tensorffield
terrancewang b2ff175
Merge branch 'main' into ethan/adding_normals
terrancewang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or raise on error if
compute_normals
is True.