Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewer visualization crashes when using DDP #863

Merged

Conversation

thomasw21
Copy link
Contributor

check_main_thread would return None in non-main processes, causing the script to crash. We now make sure to call that function only on local_rank==0

@thomasw21 thomasw21 changed the title Setup viewer only in rank 0 Viewer visualization crashes when using DDP Oct 31, 2022
Copy link
Contributor

@tancik tancik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@tancik tancik merged commit b088e23 into nerfstudio-project:main Oct 31, 2022
chris838 pushed a commit to chris838/nerfstudio that referenced this pull request Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants