Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix semantic NeRF config bug #838

Merged
merged 2 commits into from
Oct 27, 2022
Merged

Fix semantic NeRF config bug #838

merged 2 commits into from
Oct 27, 2022

Conversation

dolhasz
Copy link
Contributor

@dolhasz dolhasz commented Oct 26, 2022

Seems that there has been an update to the property naming in the NerfactoModelConfig class, which wasn't propagated into semantic_nerfw.py.

The culprit was num_proposal_network_iterations changing to num_proposal_iterations.

@kevinddchen
Copy link
Contributor

This fixes #821

tancik
tancik approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@tancik tancik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the bugfix!

@tancik tancik merged commit def6ba5 into nerfstudio-project:main Oct 27, 2022
@kevinddchen kevinddchen mentioned this pull request Oct 28, 2022
Closed
chris838 pushed a commit to chris838/nerfstudio that referenced this pull request Apr 22, 2023
@dolhasz
Fix semantic NeRF config bug (nerfstudio-project#838)
0320128 
Fix semantic nerf config bug

Co-authored-by: adolhasz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tancik tancik tancik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dolhasz @kevinddchen @tancik