Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pathlib Python 3.7 Compatibility Fix #831

Merged
merged 2 commits into from
Oct 25, 2022
Merged

Pathlib Python 3.7 Compatibility Fix #831

merged 2 commits into from
Oct 25, 2022

Conversation

akristoffersen
Copy link
Contributor

@akristoffersen akristoffersen commented Oct 24, 2022 •
edited
Loading

Small fix. the missing_ok optional arg in Path.unlink is only for Python 3.8+, so this makes it compatible with 3.7.

@akristoffersen akristoffersen linked an issue Oct 24, 2022 that may be closed by this pull request
Process Data and Download Data Scripts fail in Python 3.7 #828
Closed
tancik
tancik approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@tancik tancik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing. Good to know that the process data script now works with 3.7

@akristoffersen akristoffersen merged commit 18a6a71 into main Oct 25, 2022
@akristoffersen akristoffersen deleted the alex/pathlib_bug branch October 25, 2022 17:01
chris838 pushed a commit to chris838/nerfstudio that referenced this pull request Apr 22, 2023
@akristoffersen
Pathlib Python 3.7 Compatibility Fix (nerfstudio-project#831)
8a6bca5 
small fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tancik tancik tancik approved these changes

@ethanweber ethanweber Awaiting requested review from ethanweber

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Process Data and Download Data Scripts fail in Python 3.7
2 participants
@akristoffersen @tancik