process data to grab only JPS and PNG, disregard the small trash files #738
Conversation
|
Updated the way ns-process-data is grabbing the images. Some hidden images may appear in the image folder along with crmeta.db file from Reality Capture. Better to disregard that straight away. |
dokluch
changed the title
scripts/process_data.py
Outdated
| with CONSOLE.status("[bold yellow]Downscaling images...", spinner="growVertical"): | ||
| downscale_images(image_dir, num_downscales, verbose=verbose) | ||
| if num_frames == 0: | ||
| CONSOLE.log("[bold red]:tada: No usable images in the data folder.") |
There was a problem hiding this comment.
haha, I don't thin this deserves a 🎉
|
To run the core checks locally, call |
|
Added fix for 0th frame |
ethanweber
dismissed
their stale review
I'm not sure what the latest changes are for. I want to check that first.
| with CONSOLE.status("[bold yellow]Downscaling images...", spinner="growVertical"): | ||
| downscale_images(image_dir, num_downscales, verbose=verbose) | ||
| if num_frames == 0: | ||
| CONSOLE.log("[bold red]No usable images in the data folder.") |
There was a problem hiding this comment.
If there are no frames, I think the code should exit right after. Right?
| images_path=colmap_dir / "sparse" / "0" / "images.bin", | ||
| output_dir=output_dir, | ||
| max_side = max(Image.open(next(image_dir.glob("[!.]*"))).size) | ||
| factor = max_side // 2000 |
There was a problem hiding this comment.
Should 2000 be a parameter someone can change from the terminal? If so, we can document it there.
There was a problem hiding this comment.
Sure. I forgot this PR is still opened and pushed without consideration. I am still doing tests so I'd rather roll back a commit
|
Can you also update the name of the PR? We should merge it after you address the minor comments just to get it in. Thanks! |
Previous was expired