Quickstart Guide Fixes #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tancik
reviewed
Sep 24, 2022
scripts/run_eval.py
Outdated
| @@ -151,7 +151,7 @@ class RenderTrajectory: | |||
| # Path to config YAML file. | |||
| load_config: Path | |||
| # Name of the renderer output to use. rgb, depth, etc. | |||
| rendered_output_name: str = "rgb" | |||
| rendered_output_name: str = "rgb_fine" | |||
There was a problem hiding this comment.
Keep this default to rgb, the method we expect people to use, intant-ngp, doesn't return a coarse and fine.
This is a bit confusing for the user. Perhaps we should should add some logic like
if rendered_output_name not in outputs:
console.rule("Error", style="red")
console.print(f"Could not find {rendered_output_name} in the model outputs", justify="center")
console.print(f"Please set --rendered_output_name to one of: {outputs.keys()}")
sys.exit(1)
There was a problem hiding this comment.
Also for future branches, can you append your name to the beginning for organizational reasons (ie david/quickstart-changes). No need to this time.
There was a problem hiding this comment.
@mcallisterdavid just bumping, not sure if you saw Matt's comments here
There was a problem hiding this comment.
Hey Ethan, I got it set up on the new machine and am working through some issues. I should have some changes out tonight!
tancik
approved these changes
Oct 3, 2022
chris838
pushed a commit
to chris838/nerfstudio
that referenced
this pull request
Apr 22, 2023
* key fixes * Update README.md * Update run_eval.py * Better error reporting * lint * Removed rgb fine change * Readme updates * Justify center
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.