Restrict pymeshlab version on Windows (3461) #3474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While I have not tested your PR, I can confirm that downgrading pymeshlab to 2023.12.post1 solved the ns-export issue for me. |
jb-ye
approved these changes
Oct 24, 2024
|
I agree your proposal that we shouldn't wait for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #3461 and cnr-isti-vclab/PyMeshLab#398, currently pymeshlab==2023.12.post2 (latest at the time of writing) seems to be broken on Windows, breaking
ns-exportentirely in the process.(One could wonder why it, and everything else, is even being imported unconditionally, ns-export takes seconds to launch and uses up 900MB of RAM just to display its --help, but that's a separate issue for another time)
This is a temporary workaround to restrict the version of Pymeshlab being installed on Windows.
I blatantly admit that I have not tested this. I don't have access to a Windows machine I can test this on right now, but we've been getting at least 5 different people reporting this issue over the past few days, so I figured it was more important to roll out a potential fix than to wait until I have time to test it. Manual downgrading of pymeshlab has fixed the issue for everyone who's tried however.