Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix color shape when sh_degree=0 in splatfacto #3296

Merged
merged 2 commits into from
Jul 9, 2024
Merged

fix color shape when sh_degree=0 in splatfacto #3296

merged 2 commits into from
Jul 9, 2024

Conversation

liruilong940607
Copy link
Contributor

@liruilong940607 liruilong940607 requested review from jb-ye and kerrj July 9, 2024 17:09
jb-ye
jb-ye approved these changes Jul 9, 2024
View reviewed changes
Copy link
Collaborator

@jb-ye jb-ye left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx! could you help format the code (using ruff)?

@liruilong940607 liruilong940607 merged commit 8f5867a into main Jul 9, 2024
2 checks passed
@liruilong940607 liruilong940607 deleted the fix_sh0 branch July 9, 2024 19:11
@brentyi brentyi mentioned this pull request Aug 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jb-ye jb-ye jb-ye approved these changes

@kerrj kerrj Awaiting requested review from kerrj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sh-degree = 0 causes bug on gsplat=1.0.0
2 participants
@liruilong940607 @jb-ye