Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make awscli an optional dependency #3279

Merged

Conversation

pculbertson-bdai
Copy link
Contributor

As discussed in #3269, removes awscli from the main project dependencies in favor of a manual install by Eyeful Tower users.

Main changes:

  • Removes awscli from pyproject.toml.
  • Adds error handling on eyefultower.py prompting users to install awscli on ImportError.
  • Adds error handling to download_data.py for case when awscli is not installed.
  • Adds lines to documentation instructing Eyeful Tower users to manually install awscli.

Copy link
Collaborator

@jb-ye jb-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx

@jb-ye jb-ye enabled auto-merge (squash) July 3, 2024 19:31
@jb-ye jb-ye merged commit 592615f into nerfstudio-project:main Jul 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants