Fix parsing of non ascii image names in colmap's images.bin #3256
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If colmap image file name is non ascii an error will be thrown in the line
current_char.decode("utf-8")
while trying to parse the fileimages.bin
It is thrown because it tries to decode a single byte as
utf-8
, And non ascii chars are represented using more bytes than 1.My solution proposal is to read all the bytes, and than decode it.
I tested it and it worked OK