Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update splatfacto with gsplat 1.0 #3200

Merged
merged 20 commits into from
Jun 8, 2024
Merged

Update splatfacto with gsplat 1.0 #3200

merged 20 commits into from
Jun 8, 2024

Conversation

liruilong940607
Copy link
Contributor

@liruilong940607 liruilong940607 commented Jun 8, 2024

  • Pin dependence to gsplat==1.0.0
  • A few slight improvements on splatfacto model and its data loading, by @kerrj

This is a hot fix as the pip install nerfstudio would be failing currently because of #3197 so we need to bump a version that either pins to gsplat==1.0.0 or pins to gsplat <=1.0.0 asap.

Copy link
Collaborator

@kerrj kerrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kerrj kerrj merged commit b6d0ca0 into main Jun 8, 2024
2 checks passed
@kerrj kerrj deleted the gsplatv1.0 branch June 8, 2024 18:40
@abrahamezzeddine
Copy link

@kerrj @liruilong940607 After the update, I am getting this error now.

Traceback (most recent call last):
File "C:\Users\husse.conda\envs\nerfstudio\lib\runpy.py", line 194, in run_module_as_main
return run_code(code, main_globals, None,
File "C:\Users\husse.conda\envs\nerfstudio\lib\runpy.py", line 87, in run_code
exec(code, run_globals)
File "C:\Users\husse.conda\envs\nerfstudio\Scripts\ns-train.exe_main
.py", line 4, in
File "C:\nerf\nerfstudio\nerfstudio\scripts\train.py", line 62, in
from nerfstudio.configs.method_configs import AnnotatedBaseConfigUnion
File "C:\nerf\nerfstudio\nerfstudio\configs\method_configs.py", line 50, in
from nerfstudio.engine.trainer import TrainerConfig
File "C:\nerf\nerfstudio\nerfstudio\engine\trainer.py", line 46, in
from nerfstudio.viewer.viewer import Viewer as ViewerState
File "C:\nerf\nerfstudio\nerfstudio\viewer\viewer.py", line 37, in
from nerfstudio.models.splatfacto import SplatfactoModel
File "C:\nerf\nerfstudio\nerfstudio\models\splatfacto.py", line 103, in
def get_viewmat(optimized_camera_to_world):
File "C:\Users\husse.conda\envs\nerfstudio\lib\site-packages\torch_init
.py", line 1705, in fn
return compile(model,
File "C:\Users\husse.conda\envs\nerfstudio\lib\site-packages\torch_init
.py", line 1723, in compile
return torch._dynamo.optimize(backend=backend, nopython=fullgraph, dynamic=dynamic, disable=disable)(model)
File "C:\Users\husse.conda\envs\nerfstudio\lib\site-packages\torch_dynamo\eval_frame.py", line 583, in optimize
check_if_dynamo_supported()
File "C:\Users\husse.conda\envs\nerfstudio\lib\site-packages\torch_dynamo\eval_frame.py", line 535, in check_if_dynamo_supported
raise RuntimeError("Windows not yet supported for torch.compile")
RuntimeError: Windows not yet supported for torch.compile

Any suggestions?

@liruilong940607
Copy link
Contributor Author

@abrahamezzeddine fixed in #3202

@abrahamezzeddine
Copy link

abrahamezzeddine commented Jun 9, 2024

@liruilong940607 Is it possible to use packed as True with splatfacto? I tried to use it but it says the tensors are not matched if set to true.

Would be nice if I could trade speed vs memory.

@liruilong940607
Copy link
Contributor Author

@abrahamezzeddine This PR is just a quick fix that makes the nerfstudio model compatible with gsplat v1.0. To fully support all functionalities of gsplat v1.0, there are still quite some upgrades need to be done. So please stay tuned! (Contribution is always welcomed!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants