Only import pycolmap in run_hloc #3146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
KevinXu02
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ns process data will immediately crash when trying to import pycolmap in windows. this pr stops trying to import pycolmap when initializing. as pycolmap is only used in hloc, this shouldn't be a problem.
*** Aborted at 1715751746 (unix time) try "date -d @1715751746" if you are using GNU date ***
@ 0x7ffe98de4132 log2f
@ 0x7ff7ce112698 OPENSSL_Applink
@ 0x7ffe4a74e390 __C_specific_handler
@ 0x7ffe9b6f440f __chkstk
@ 0x7ffe9b66e466 RtlFindCharInUnicodeString
@ 0x7ffe9b6f33fe KiUserExceptionDispatcher
@ 0x7ffe3c3225ee void __cdecl __ExceptionPtrRethrow(void const * __ptr64)
@ 0x7ffcea0ee80e public: void __cdecl c10::ivalue::Future::markCompleted(void) __ptr64
@ 0x7ffcea101ae7 public: class pybind11::object const & __ptr64 __cdecl pybind11::error_already_set::trace(void)const __ptr64
@ 0x7ffce97cdec5 (unknown)
@ 0x7ffce9d26b29 PyInit_pycolmap
@ 0x7ffe4a811080 (unknown)
@ 0x7ffe4a8126a5 __NLG_Return2
@ 0x7ffe9b6f3c56 RtlCaptureContext2
@ 0x7ffce97d0936 (unknown)
@ 0x7ffe258d6f60 _PyMethodDef_RawFastCallKeywords
@ 0x7ffe258d5f26 _PyObject_MakeTpCall
@ 0x7ffe258e266b PyWrapper_New
@ 0x7ffe2591e34a _PyObject_GenericGetAttrWithDict
@ 0x7ffe2591d939 PyObject_GetAttrString
@ 0x7ffce9805dfe PyInit_pycolmap
@ 0x7ffce985d98d PyInit_pycolmap
@ 0x7ffce983628d PyInit_pycolmap
@ 0x7ffce97f3ed0 (unknown)
@ 0x7ffce98007a8 PyInit_pycolmap
@ 0x7ffce98002ae PyInit_pycolmap
@ 0x7ffe259e21cd PyImport_AppendInittab
@ 0x7ffe259e1896 PyImport_Import
@ 0x7ffe259194b5 _PyCFunction_DebugMallocStats
@ 0x7ffe258d606e PyVectorcall_Call
@ 0x7ffe259b3a20 PyEval_GetFuncDesc
@ 0x7ffe259b0571 _PyEval_EvalFrameDefault