-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make RealityCapture csv/ply exports work! #3131
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
@jb-ye You mentioned "safeguard brown4 tangential2 distortion model in full data manager, since opencv's undistort doesn't support it.". However, from my testing, changing |
@shengjie-lin cv2.undistort takes k4, k5, k6 but they are used in the division model's denominator. The camera model supported by cv2.undistort is non-standard. Standard B4 model use k4 for the highest order polynomial term. In nerfstudio, we intend to support the standard Brown Tangential model, which is the case for nerfacto and other nerf models. |
Thanks for the explanation @jb-ye . Does this mean COLMAP or hloc tool box also estimate the distortion coefficients in a non-compatible format from what opencv expects (specifically for the k4)? |
@shengjie-lin I am not sure about COLMAP, it support several cameras models. The FULL_OPENCV might be something you are looking for. |
fix #3118
Changes in this PR:
ns-process-data realitycapture
to support splatfacto