Fix bug when trying to create a camera path in viewer #3016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MildMystery
changed the title
kerrj
approved these changes
Mar 24, 2024
Michael-Spleenlab
pushed a commit
to Michael-Spleenlab/nerfstudio
that referenced
this pull request
Apr 26, 2024
…ject#3016) * Directly import interpolate function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue that I see when trying to add multiple keyframes in the viewer to generate a camera path for rendering. I get the following error:
FYI, I don't see this error when trying to create a camera path running the legacy viewer i.e. when I try to create a path after running
ns-viewer --load-config outputs/test_data/nerfacto/2024-03-23_151802/config.yml --vis viewer-legacyinstead ofns-viewer --load-config outputs/test_data/nerfacto/2024-03-23_151802/config.yml