fix nerfstudio collate function #2965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jb-ye
reviewed
Apr 30, 2024
| metadata = None | ||
|
|
||
| if batch[0].distortion_params is not None: | ||
| assert all( |
There was a problem hiding this comment.
I believe this assertion for distortion_params is redundant since at the beginning of the function, we have
assert all((cam.distortion_params is None for cam in batch)) or all(
(cam.distortion_params is not None for cam in batch)
| distortion_params = None | ||
|
|
||
| if batch[0].times is not None: | ||
| assert all((cam.times is not None for cam in batch)), "All cameras must have times present or absent." |
There was a problem hiding this comment.
Can we move this assert to the beginning of the function just like what we did for distortion_params?
| metadata = {key: op([cam.metadata[key] for cam in batch], dim=0) for key in metadata_keys} | ||
| if batch[0].metadata is not None: | ||
| metadata_keys = batch[0].metadata.keys() | ||
| assert all( |
There was a problem hiding this comment.
Can we move this assert to the beginning of the function just like what we did for distortion_params?
|
@jb-ye hopefully the latest update addresses your PR feedback! |
jb-ye
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the nerfstudio collate function in cases where metadata, distortion, or times isn't specified in the cameras structure to collate.