Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upper-bound torch version for dev installs only #2864

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

brentyi
Copy link
Collaborator

@brentyi brentyi commented Feb 2, 2024

Since we only upper-bound to suppress some type errors!

@brentyi brentyi requested a review from tancik February 2, 2024 00:07
Copy link
Contributor

@tancik tancik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tancik tancik enabled auto-merge (squash) February 2, 2024 00:07
@tancik tancik merged commit 6436742 into main Feb 2, 2024
2 checks passed
@tancik tancik deleted the brent/upper_bound_torch_dev_only branch February 2, 2024 00:19
ArpegorPSGH pushed a commit to ArpegorPSGH/nerfstudio that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants