-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace depth alpha mask logic with torch.where for gradients in splatfacto #2856
Merged
Merged
Changes from all commits
Commits
Show all changes
92 commits
Select commit
Hold shift + click to select a range
70ade42
fix jittering in markdown in viewer beta
kerrj 622342c
Revert "fix jittering in markdown in viewer beta"
kerrj 072c3ed
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
kerrj d68138d
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
kerrj e65d14e
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
kerrj 39637f0
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
kerrj c30d0c8
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
kerrj 5723357
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
kerrj 8a08740
print correctly formatted url in banner for viewer beta
kerrj 246d731
merge
kerrj a7b08df
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
kerrj fa8909e
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
kerrj eab1f7a
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
kerrj 86ff630
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
kerrj cf41e63
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
kerrj 09cc1d1
fix the bug when camera.distortion_params is None
KevinXu02 a4e640b
Handle background color override when using blender.
KevinXu02 bd07a71
fix bare except
KevinXu02 2fcd556
format
KevinXu02 00d10a1
Update background color override in Blender dataparser
KevinXu02 2bf8a06
Merge branch 'main' into main
KevinXu02 db13cfa
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
kerrj 5ca2be0
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
kerrj 172cf07
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
kerrj 1559504
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
kerrj 2158946
Add ability to download EyefulTower dataset
VasuAgrawal ba5ce12
wip before I copy linning's stuff in
VasuAgrawal f95b4eb
Generate per-resolution cameras.xml
VasuAgrawal f811bd2
Generate transforms.json at download
VasuAgrawal 59e1cf6
Fix a couple of quotes
VasuAgrawal 688c39b
Use official EyefulTower splits for train and val
VasuAgrawal 25b6d58
Disable projectaria-tools on windows
VasuAgrawal 0e7d29e
Fix extra imports
VasuAgrawal 5393ee4
Add a new nerfacto method tund for EyefulTower
VasuAgrawal 8fb0a8b
Split eyefultower download into a separate file
VasuAgrawal ad91608
Merge branch 'main' into main
KevinXu02 c481c29
Fix typo
KevinXu02 88c644a
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstud…
VasuAgrawal ac5200a
Add some fisheye support for eyeful data
VasuAgrawal 6998760
Reformatted imports to not be dumb
VasuAgrawal 82d4f5e
Apparently this file was missed when formatting originally
VasuAgrawal 93436d4
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
kerrj 91c6b49
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
kerrj c912066
Merge branch 'main' into main
KevinXu02 c012963
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
kerrj 9620061
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
kerrj bf6d7b7
Added 1k resolution scenes
VasuAgrawal 7126694
revert method_configs.py to original values
VasuAgrawal e5c5601
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
kerrj 06011f5
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
kerrj e24ffe0
Also add 1k exrs
VasuAgrawal bf12b3e
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
kerrj 8dd3123
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
kerrj a022a57
Add option to modify bg color in gaussian splatting
KevinXu02 950f990
Merge branch 'main' of https://github.com/KevinXu02/nerfstudio
KevinXu02 c95d3f3
Merge branch 'main' into main
KevinXu02 999e63c
fix back the config, bg color should work now
KevinXu02 bae5a5f
removed camera optimizer for gs to align with main
KevinXu02 6c3c576
Merge branch 'main' into main
KevinXu02 44581bf
Address feedback
VasuAgrawal 544cb81
Revert changes to pyproject.toml, to be added in a later PR
VasuAgrawal 59333c9
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstud…
VasuAgrawal d1abe18
Oops, probably shouldn't have gotten rid of awscli ...
VasuAgrawal be6792f
adding support for bg color, tested and reformatted now
KevinXu02 a142ba7
Merge branch 'main' into main
KevinXu02 8afc649
formatted
KevinXu02 a10c777
formatted
KevinXu02 ce39177
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
kerrj ce7bb78
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
kerrj a791591
merged main
ethanweber cdd1d15
changed glob variable name
ethanweber 36c8a59
Merge commit 'cdd1d1507e78c92fdf0c192a2b2739950dec7d7c'
KevinXu02 3fdb4fa
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
kerrj 67b11f4
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
kerrj dcd361a
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
kerrj 1be957d
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
kerrj 53c8646
Merge branch 'main' of https://github.com/KevinXu02/nerfstudio into K…
kerrj 8e3cfca
Merge branch 'KevinXu02-main'
kerrj 40c3553
Revert "Remove legacy viewer from GitHub actions (#2798)"
kerrj 5fc2f28
merge
kerrj a4c03d4
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
kerrj fdd1bff
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
kerrj 7f28d72
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
kerrj 12c0b12
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
kerrj 256ae29
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
kerrj fec34e8
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
kerrj 54dbb5f
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
kerrj 2ed1a71
replace alpha depth logic with torch.where for differentiability
kerrj 830f20b
rm weird file
kerrj f7630fd
Merge branch 'main' into justin/fix_splat_depth
kerrj 2245df7
Merge branch 'main' into justin/fix_splat_depth
kerrj 47c9100
Merge branch 'main' into justin/fix_splat_depth
kerrj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just an unrelated comment, compute the mean(depth) has very high variance in estimation. I would prefer to compute mean(1/depth) as this is more related to disparity maps across views.