Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to disable apperance embedding #2843

Merged
merged 3 commits into from
Jan 29, 2024

Conversation

jkulhanek
Copy link
Contributor

No description provided.

@jkulhanek jkulhanek force-pushed the jkulhanek/add-use-appearance-embeding-flag branch from 21d8971 to c3db1b6 Compare January 29, 2024 14:31
@jkulhanek jkulhanek enabled auto-merge (squash) January 29, 2024 14:31
Copy link
Collaborator

@brentyi brentyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggested one change, but also looks good to me in the current state!

nerfstudio/fields/nerfacto_field.py Show resolved Hide resolved
nerfstudio/fields/nerfacto_field.py Show resolved Hide resolved
@jkulhanek jkulhanek merged commit 4779f81 into main Jan 29, 2024
2 checks passed
@jkulhanek jkulhanek deleted the jkulhanek/add-use-appearance-embeding-flag branch January 29, 2024 23:07
@jkulhanek
Copy link
Contributor Author

Sorry, I had auto-merge turned on :( I would have updated it.

jkulhanek added a commit that referenced this pull request Jan 30, 2024
jkulhanek added a commit that referenced this pull request Jan 30, 2024
jkulhanek added a commit that referenced this pull request Jan 30, 2024
jkulhanek added a commit that referenced this pull request Jan 30, 2024
ArpegorPSGH pushed a commit to ArpegorPSGH/nerfstudio that referenced this pull request Jun 22, 2024
ArpegorPSGH pushed a commit to ArpegorPSGH/nerfstudio that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants