Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add alpha rendering to splatfacto, fix depth bug #2824

Merged
merged 88 commits into from
Jan 25, 2024
Merged

Add alpha rendering to splatfacto, fix depth bug #2824

merged 88 commits into from
Jan 25, 2024

Conversation

kerrj
Copy link
Collaborator

@kerrj kerrj commented Jan 25, 2024 •
edited
Loading

Fixes a bug in depth rendering which ignores transmittance values of non-saturated pixels, adds alpha rendering to splatfacto with the accumulation output, which can be used for alpha supervision, compositing, etc.

kerrj and others added 30 commits October 10, 2023 17:11
@kerrj
fix jittering in markdown in viewer beta
70ade42
@kerrj
Revert "fix jittering in markdown in viewer beta"
622342c 
This reverts commit 70ade42.
@kerrj
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
072c3ed
@kerrj
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
d68138d
@kerrj
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
e65d14e
@kerrj
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
39637f0
@kerrj
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
c30d0c8
@kerrj
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
5723357
@kerrj
print correctly formatted url in banner for viewer beta
8a08740
@kerrj
merge
246d731
@kerrj
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
a7b08df
@kerrj
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
fa8909e
@kerrj
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
eab1f7a
@kerrj
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
86ff630
@kerrj
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
cf41e63
@KevinXu02
fix the bug when camera.distortion_params is None
09cc1d1
@KevinXu02
Handle background color override when using blender.
a4e640b
@KevinXu02
fix bare except
bd07a71
@KevinXu02
format
2fcd556
@KevinXu02
Update background color override in Blender dataparser
00d10a1
@KevinXu02
Merge branch 'main' into main
2bf8a06
@kerrj
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
db13cfa
@kerrj
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
5ca2be0
@kerrj
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
172cf07
@kerrj
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
1559504
@VasuAgrawal
Add ability to download EyefulTower dataset
2158946
@VasuAgrawal
wip before I copy linning's stuff in
ba5ce12
@VasuAgrawal
Generate per-resolution cameras.xml
f95b4eb
@VasuAgrawal
Generate transforms.json at download
f811bd2
@VasuAgrawal
Fix a couple of quotes
59e1cf6
KevinXu02 and others added 24 commits January 18, 2024 21:08
@KevinXu02
adding support for bg color, tested and reformatted now
be6792f
@KevinXu02
Merge branch 'main' into main
a142ba7
@KevinXu02
formatted
8afc649
@KevinXu02
formatted
a10c777
@kerrj
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
ce39177
@kerrj
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
ce7bb78
@ethanweber
merged main
a791591
@ethanweber
changed glob variable name
cdd1d15
@KevinXu02
Merge commit 'cdd1d1507e78c92fdf0c192a2b2739950dec7d7c'
36c8a59
@kerrj
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
3fdb4fa
@kerrj
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
67b11f4
@kerrj
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
dcd361a
@kerrj
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
1be957d
@kerrj
Merge branch 'main' of https://github.com/KevinXu02/nerfstudio into K…
53c8646 
…evinXu02-main
@kerrj
Merge branch 'KevinXu02-main'
8e3cfca
@kerrj
Revert "Remove legacy viewer from GitHub actions (#2798)"
40c3553 
This reverts commit 70d83d4.
@kerrj
merge
5fc2f28
@kerrj
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
a4c03d4
@kerrj
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
fdd1bff
@kerrj
Merge branch 'main' of https://github.com/nerfstudio-project/nerfstudio
7f28d72
@kerrj
add correction to depth rendering and add alpha output as transmittance
80f3560
@kerrj
rm accidental file
c92ebd9
@kerrj
typo
7dcc078
@kerrj
Merge branch 'main' into justin/depth_and_alpha
fbc5ba1
@kerrj kerrj requested a review from vye16 January 25, 2024 19:11
vye16
vye16 approved these changes Jan 25, 2024
View reviewed changes
Copy link
Collaborator

@vye16 vye16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kerrj kerrj merged commit f2f4bf5 into main Jan 25, 2024
2 checks passed
@kerrj kerrj deleted the justin/depth_and_alpha branch January 25, 2024 20:51
ArpegorPSGH pushed a commit to ArpegorPSGH/nerfstudio that referenced this pull request Jun 22, 2024
@kerrj @ArpegorPSGH
Add alpha rendering to splatfacto, fix depth bug (nerfstudio-project#…
aafbded 
…2824)

* Add alpha rendering to splatfacto, output as accumulation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vye16 vye16 vye16 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kerrj @vye16 @KevinXu02 @VasuAgrawal @ethanweber