Mask flexibility for methods than need to sample in the masked region #2647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanweber
changed the title
ethanweber
requested review from
kerrj
and removed request for
brentyi and
kerrj
ArpegorPSGH
pushed a commit
to ArpegorPSGH/nerfstudio
that referenced
this pull request
Jun 22, 2024
…nerfstudio-project#2647) * minor changes to make masking more flexible * formatting * updating ignore mask --------- Co-authored-by: Justin Kerr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm making minor changes to make the masking feature more flexible. I have a method where I want to sample everywhere in the image, including the masked out regions, as specified in the
transforms.jsonfile. My custom model will compute losses differently depending on where it is masked out.Furthermore, I sometimes want to give the masked out region a specific color. A minor modification to the dataloading and dataset enables this.
Lastly, I expose the trainer to the callback because my pipeline needs access to this, specifically to read off the
base_dirso I can avoid wandb.