Add kwargs handling for patchpixelsampler patch size #2622
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PatchPixelSamplerConfig
has apatch_size
item, but the currentPatchPixelSampler
init function doesn't override the value ofpatch_size
with the correspondingkwargs
value.This is particularly problematic, because
PatchPixelSamplerConfig
is generated within the datamanager:nerfstudio/nerfstudio/data/datamanagers/base_datamanager.py
Line 472 in 9528a3f
This PR simply adds the
__init__
function for the sampler and adds aself.config.patch_size = self.kwargs.get(...
.As an aside, it would be good if this override could happen automatically...