Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PCA colormap bug for float output maps #2620

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Remove PCA colormap bug for float output maps #2620

merged 3 commits into from
Nov 27, 2023

Conversation

chungmin99
Copy link
Contributor

Original viewer used to remove both "default" and "pca" colormaps for the float output maps:

colormap_options = [c for c in list(get_args(Colormaps)) if c not in ("default", "pca")]

However, this is not replicated in the viewer_beta:

colormap_options = [c for c in list(get_args(Colormaps)) if c != "default"]

This causes problems when "PCA" is offered as a colormap option (and throws "PCA is not a known colormap" error).
image

This PR is a one-line change for the bugfix.

@chungmin99 chungmin99 changed the title Remove bug Remove PCA colormap bug for float output maps Nov 19, 2023
@chungmin99 chungmin99 merged commit c896ee4 into main Nov 27, 2023
4 checks passed
@chungmin99 chungmin99 deleted the cmk/pca-bug branch November 27, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants