Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove compile line in camera_utils #2584

Merged
merged 3 commits into from
Nov 5, 2023
Merged

Remove compile line in camera_utils #2584

merged 3 commits into from
Nov 5, 2023

Conversation

ginazhouhuiwu
Copy link
Contributor

@ginazhouhuiwu ginazhouhuiwu commented Nov 5, 2023 •
edited
Loading

Re commit 85677d3, which caused the following when training nerfacto:

Screenshot 2023-11-05 at 8 37 42 AM
Screenshot 2023-11-05 at 8 37 58 AM

@tancik
Copy link
Contributor

tancik commented Nov 5, 2023

@jkulhanek FYI

@ginazhouhuiwu ginazhouhuiwu changed the title Revert "Fix torch.compile for torch 2.1 (#2577)" Remove compile line in camera_utils Nov 5, 2023
@ginazhouhuiwu
Copy link
Contributor Author

Removing the compile line instead of reverting changes since reverting it will break torch 2.1

@ginazhouhuiwu ginazhouhuiwu merged commit 1f6fb83 into main Nov 5, 2023
4 checks passed
@ginazhouhuiwu ginazhouhuiwu deleted the mainfix branch November 5, 2023 18:21
@jkulhanek
Copy link
Contributor

This can have bad consequences. Removing torch.compile will make it much slower.

@ginazhouhuiwu
Copy link
Contributor Author

I believe this is just a temporary solution for now since main was having some issues. Will try to patch this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tancik tancik tancik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ginazhouhuiwu @tancik @jkulhanek