New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pixel-perfect-sfm installation in Dockerfile #2549

Merged

tancik merged 1 commit into nerfstudio-project:main from ori-systems:fix_dockerfile

Oct 20, 2023

Contributor

2b-t commented Oct 20, 2023

Building the Dockerfile of the current main branch fails with the error message

failed to solve: process "/bin/bash -c git clone --recursive https://github.com/cvg/pixel-perfect-sfm.git &&     git reset --hard 40f7c1339328b2a0c7cf71f76623fb848e0c0357 &&     git clean -df &&     cd pixel-perfect-sfm &&     python3.10 -m pip install -e . &&     cd .." did not complete successfully: exit code: 128

due to the wrong order of the commands introduced in #2446. This pull request fixes this by inverting their order.


          fix: Fix pixel-perfect-sfm installation in Dockerfile

b3d35df

tancik approved these changes

View reviewed changes

tancik enabled auto-merge (squash)

October 20, 2023 18:34

tancik merged commit 23cc960 into nerfstudio-project:main

4 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet