fix:correction of PairPixelSampler in case of using masks with depth-nerfacto #2477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
When I try to train depth-nerfacto with mask, assert below pop:
File "/home/pierre.merriaux/project/nerfstudio/nerfstudio/data/pixel_samplers.py", line 176, in collate_image_dataset_batch
assert collated_batch["image"].shape[0] == num_rays_per_batch
It is because in PairPixelSampler in case of using masks, indices are returned with shape self.rays_to_sample and self.rays_to_sample = self.config.num_rays_per_batch // 2.
I added pair_indices stacking as without using masks. I will push the PR soon