Track all viser GUI folders to avoid folder duplicates (viewer-beta) #2466
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current "Custom Elements" folder generation, you end up with duplicate folder structures like below:
Given this ViewerText in nerfacto.py
The folder appears as
This is because viser's
gui_add_folder
creates a unique ID for every folder -- there can exist two folders with the exact same names, but with different IDs --> duplicate structures.nerfstudio/nerfstudio/viewer_beta/viewer.py
Line 171 in 53037ba
This PR changes the viewer element population code to keep track of all the generated folders (with their respective paths), so that the previously folder contexts are used instead of re-generating them (if applicable).
With the PR the structure should be fixed:
, with it also working for nested structures as expected (adding ViewerTexts in nerfacto_field.py):