Fourier Feature encodings and polyhedron encodings

[Mxbonn]

Rework RFFEncoding to be a subclass of the more general Fourier Feature Encodings and introduce Polyhedron encodings as introduced in mipnerf360.

[Mxbonn]

pyright is really not liking the self.b_matrix as it comes from a buffer. Anyone knows how to tell it that self.b_matrix.shape is a tuple of ints? For now just using ignore.
Slightly unrelated but I cannot get to run pyright locally as it does not recognize jaxtyping.

[jkulhanek]

Thank you for this PR!

[jkulhanek]

pyright is really not liking the self.b_matrix as it comes from a buffer. Anyone knows how to tell it that self.b_matrix.shape is a tuple of ints? For now just using ignore. Slightly unrelated but I cannot get to run pyright locally as it does not recognize jaxtyping.

What is the exact error?

[Mxbonn]

pyright is really not liking the self.b_matrix as it comes from a buffer. Anyone knows how to tell it that self.b_matrix.shape is a tuple of ints? For now just using ignore. Slightly unrelated but I cannot get to run pyright locally as it does not recognize jaxtyping.

What is the exact error?

error: "__getitem__" method not defined on type "Module" (reportGeneralTypeIssues) for the line that does: out_dim = self.b_matrix.shape[1] * self.num_frequencies * 2

[jkulhanek]

Can you just add an assert at the beginning of the block code where you have the error?

assert isinstance(self.b_matrix, torch.Tensor)

[jkulhanek]

Slightly unrelated but I cannot get to run pyright locally as it does not recognize jaxtyping.

I think I had to uninstall torchtyping, but I don't remember, sorry :/

[jkulhanek]

Please remove type:ignore

[Mxbonn]

Can you just add an assert at the beginning of the block code where you have the error?

assert isinstance(self.b_matrix, torch.Tensor)

Thanks, that indeed did the trick! I have dropped the ignore lines now.

[jkulhanek]

This have to be offset. See the docs error:

/home/runner/work/nerfstudio/nerfstudio/nerfstudio/utils/math.py:docstring of nerfstudio.utils.math.generate_polyhedron_basis:8: ERROR: Unexpected indentation.
/home/runner/work/nerfstudio/nerfstudio/nerfstudio/utils/math.py:docstring of nerfstudio.utils.math.generate_polyhedron_basis:9: WARNING: Block quote ends without a blank line; unexpected unindent.
/home/runner/work/nerfstudio/nerfstudio/nerfstudio/utils/math.py:docstring of nerfstudio.utils.math.generate_polyhedron_basis:14: WARNING: Definition list ends without a blank line; unexpected unindent.

[jkulhanek]

Same here

[jkulhanek]

Can we perhaps make private functions (not needed to be exported) to start with underscore (_)?

[Mxbonn]

Sure, and is it fine that I put them in utils/math.py or would you prefer to have them in a new separate utils file?

[jkulhanek]

Its fine to have them there I think

[jkulhanek]

@tancik , do you agree with merging?

[tancik]

LGTM, nice abstraction