Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate doc from RTD to gh-pages #2460

Merged
merged 9 commits into from
Sep 23, 2023
Merged

Migrate doc from RTD to gh-pages #2460

merged 9 commits into from
Sep 23, 2023

Conversation

liruilong940607
Copy link
Contributor

@liruilong940607 liruilong940607 commented Sep 23, 2023 •
edited
Loading

Workflow action for gh-pages.

New doc link: https://nerfstudio-project.github.io/nerfstudio

Need to update DNS (@tancik) and CNAME (in this PR @liruilong940607).

tancik
tancik reviewed Sep 23, 2023
View reviewed changes
Copy link
Contributor

@tancik tancik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets first set this up, then delete rtd once it is working.

.readthedocs.yaml Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this in followup PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok makes sense

@liruilong940607
Copy link
Contributor Author

Fail on warning is tested:

https://github.com/nerfstudio-project/nerfstudio/actions/runs/6281838816/job/17060658890

@liruilong940607
Copy link
Contributor Author

liruilong940607 commented Sep 23, 2023 •
edited
Loading

++ vis @brentyi @jake-austin

tancik
tancik approved these changes Sep 23, 2023
View reviewed changes
Copy link
Contributor

@tancik tancik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for migrating!

@tancik tancik merged commit e0f0cd0 into main Sep 23, 2023
@tancik tancik deleted the migrate_doc branch September 23, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tancik tancik tancik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liruilong940607 @tancik