-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move camera optimization out of datamanager and parallelize dataloading #2092
Conversation
https://github.com/nerfstudio-project/nerfstudio/blob/justin/camera_opt_refactor/nerfstudio/pipelines/base_pipeline.py#L363 may be fixed to |
…ere the messages are coming from, add default optimizer to optimizers.py for camera_opt param group to avoid crashes
I think this is ready for merge. Tested with Lerf repository out of the box, and warnings appeared as they should without breaking the pipeline. Users would have to pip install nerfstudio once again after this update, since viser version has been bumped up. |
pytest failed :/ |
The ParallelDataManager (see nerfstudio-project#2092) makes pytorch crash if the cameras instance's fx, fy, cx or cy tensors are loaded from a common shared tensor
The ParallelDataManager (see nerfstudio-project#2092) makes pytorch crash if the cameras instance's fx, fy, cx or cy tensors are loaded from a common shared tensor. This PR fixes the issue by cloning the respective tensors before passing them to the Cameras(...) constructor.
The ParallelDataManager (see nerfstudio-project#2092) makes pytorch crash if the cameras instance's fx, fy, cx or cy tensors are loaded from a common shared tensor. This PR fixes the issue by cloning the respective tensors before passing them to the Cameras(...) constructor.
The ParallelDataManager (see nerfstudio-project#2092) makes pytorch crash if the cameras instance's fx, fy, cx or cy tensors are loaded from a common shared tensor. This PR fixes the issue by cloning the respective tensors before passing them to the Cameras(...) constructor.
The ParallelDataManager (see #2092) makes pytorch crash if the cameras instance's fx, fy, cx or cy tensors are loaded from a common shared tensor. This PR fixes the issue by cloning the respective tensors before passing them to the Cameras(...) constructor.
WIP for removing camera optimization from datamanger and moving it to the model. This will potentially allow significant speedups in dataloading as several people have already noted, since the most time consuming step in dataloading is ray generation, which currently depends on gradients from the camera optimizer and thus cannot be parallelized.
Currently this
Things that need to happen: