Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Dockerfile versions, add user to sudoers list. #1448

Merged
merged 7 commits into from
Feb 19, 2023

Conversation

Zunhammer
Copy link
Contributor

  • Bump CUDA from 11.7 to 11.8 (should improve computation times for new GPUs a little)
  • Bump Colmap from 3.7 to 3.8
  • Added the user ('user') to sudoers list withput password prompting. Now you can use elevated rights, e.g. by typing sudo apt update
  • Added curl (required for some download tasks)
  • Some small improvements
  • Updated docs

@pablovela5620
Copy link
Contributor

May be out of scope but would also be awesome to add in bloc support to docker file #1412

Copy link
Contributor

@tancik tancik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for keeping this up-to-date! Note that there is now a dev container -

image: dromni/nerfstudio:0.1.17

I think it is pointing to the most up to date version.

@Zunhammer
Copy link
Contributor Author

Hey Tancik,
thanks for pointing this out, I actually missed the docker-compose file. It is pointing to the latest version of the image and is only pre-configuring all the parameters you'd usually have to give, so everything fine. I also was thinking of doing this, good to know that someone else alrady did :)

I can also have a look into the mentioned issue, however this is independant of this PR.

Best,
Nico

@Zunhammer Zunhammer merged commit 2901e5f into nerfstudio-project:main Feb 19, 2023
jkulhanek pushed a commit to jkulhanek/nerfstudio that referenced this pull request Feb 27, 2023
…ct#1448)

* Update Dockerfile, bump CUDA from 11.7.1 to 11.8.0, bump Colmap from 3.7 to 3.8, add user to sudoers list.

* Improve description.

* Fix wrong description and typos.

* Add better description.

* Fix build error of Dockerfile.

* Bump pytorch versions.

---------

Co-authored-by: Nicolas Zunhammer <[email protected]>
chris838 pushed a commit to chris838/nerfstudio that referenced this pull request Apr 22, 2023
…ct#1448)

* Update Dockerfile, bump CUDA from 11.7.1 to 11.8.0, bump Colmap from 3.7 to 3.8, add user to sudoers list.

* Improve description.

* Fix wrong description and typos.

* Add better description.

* Fix build error of Dockerfile.

* Bump pytorch versions.

---------

Co-authored-by: Nicolas Zunhammer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants