Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ns-install-cli #1396

Merged
merged 7 commits into from
Feb 15, 2023
Merged

Improve ns-install-cli #1396

merged 7 commits into from
Feb 15, 2023

Conversation

jkulhanek
Copy link
Contributor

This PR implements the following:

  • All entrypoints are automatically registered for ns-install-cli completions
  • ns-install-cli detects conda environment and instead of putting the activation scripts to bashrc or zshrc it uses the activation scripts of the conda environment.

@tancik tancik requested a review from brentyi February 10, 2023 21:19
@brentyi
Copy link
Collaborator

brentyi commented Feb 11, 2023

I need some more time to fully go through this but just wanted to say this looks really clean @jkulhanek!

Not in scope here, but I'm wondering if there's a clean way to merge some of this logic upstream into tyro, especially since the script looks even less nerfstudio-specific now. It'd be really cool if we had a completion setup flow like this for all tyro.cli() applications.

brentyi
brentyi reviewed Feb 12, 2023
View reviewed changes
Copy link
Collaborator

@brentyi brentyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through the install process and only had one minor issue, if that's resolved I think this is good to merge :)

scripts/completions/install.py Show resolved Hide resolved
scripts/completions/install.py Outdated Show resolved Hide resolved
scripts/completions/install.py Outdated Show resolved Hide resolved
@jkulhanek jkulhanek merged commit 97498e3 into nerfstudio-project:main Feb 15, 2023
jkulhanek added a commit to jkulhanek/nerfstudio that referenced this pull request Feb 27, 2023
@jkulhanek
Improve ns-install-cli (nerfstudio-project#1396)
27d9dcd 
* Improve ns-install-cli

* Remove unused code

* ns-install-cli conda specify encoding explicitly

* Fix missing directory in ns-install-cli

* Implement ns-install-cli deactivate for conda env

* ns-install-cli: conda create deactivate.d
chris838 pushed a commit to chris838/nerfstudio that referenced this pull request Apr 22, 2023
@jkulhanek
Improve ns-install-cli (nerfstudio-project#1396)
9cc7960 
* Improve ns-install-cli

* Remove unused code

* ns-install-cli conda specify encoding explicitly

* Fix missing directory in ns-install-cli

* Implement ns-install-cli deactivate for conda env

* ns-install-cli: conda create deactivate.d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentyi brentyi brentyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkulhanek @brentyi