Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for is_fisheye flag in ingp transforms.json #1385

Merged
merged 2 commits into from
Feb 10, 2023

Conversation

jkulhanek
Copy link
Contributor

This PR adds the support for instant-ngp "is_fisheye" flag in the transforms.json file.

Copy link
Contributor

@tancik tancik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tancik tancik merged commit 27b7132 into nerfstudio-project:main Feb 10, 2023
machenmusik added a commit to machenmusik/nerfstudio that referenced this pull request Feb 13, 2023
commit 9808ebb
Author: Matthew Tancik <[email protected]>
Date:   Sun Feb 12 11:14:12 2023 -0800

    v0.1.17 (nerfstudio-project#1409)

commit 2b52f51
Author: Matthew Tancik <[email protected]>
Date:   Sun Feb 12 11:05:59 2023 -0800

    Downgrade nerfacc to 0.3.3 (nerfstudio-project#1408)

    reset nerfacc to 0.3.3

commit a37c73f
Author: Pablo Vela <[email protected]>
Date:   Sun Feb 12 12:31:31 2023 -0600

    sdfstudio dataparser/dataset (nerfstudio-project#1381)

    * add downloads for sdfstudio datasets

    * add sdfstudio parser to work with sdfstudio data

    * fix licensing and doc strings

    * fix linter errors

    * move depths/normals to metadata, create sdfdataset

    * remove extra scenebox parameters

    * more linting errors fix

    * fix wrong annotation

    * add in missing depth/normal files

    * minor fixes

    ---------

commit 71eacd5
Author: Matthew Tancik <[email protected]>
Date:   Sat Feb 11 10:51:22 2023 -0800

    Update reality capture doc (nerfstudio-project#1404)

commit 259f3aa
Author: Mark Colley <[email protected]>
Date:   Fri Feb 10 18:30:57 2023 -0500

    Fix IPython error display (nerfstudio-project#1397)

commit 3cf2bb0
Author: Matthew Tancik <[email protected]>
Date:   Thu Feb 9 18:26:13 2023 -0800

    Update citation (nerfstudio-project#1392)

commit 448e107
Author: Matthew Tancik <[email protected]>
Date:   Thu Feb 9 17:55:51 2023 -0800

    Update doc link

commit 6368340
Author: Jonáš Kulhánek <[email protected]>
Date:   Fri Feb 10 02:31:16 2023 +0100

    Add ns-viewer command to run viewer only with model in eval mode (nerfstudio-project#1379)

    * Add ns-viewer command to run only viewer with model in eval mode

    * Remove profiler and logger

    * Fix ns-viewer

    * ns-viewer remove writer.setup_local_writer

    * ns-viewer add writer.setup_local_writer

    * ns-viewer: update docs

    * Delete outputs

commit 27b7132
Author: Jonáš Kulhánek <[email protected]>
Date:   Fri Feb 10 02:23:33 2023 +0100

    Add support for is_fisheye flag in ingp transforms.json (nerfstudio-project#1385)

commit b653eef
Author: LSong <[email protected]>
Date:   Thu Feb 9 16:43:21 2023 -0800

    add time (nerfstudio-project#1391)

    * add time

    * fix black

    ---------

    Co-authored-by: LcDog <[email protected]>
chris838 pushed a commit to chris838/nerfstudio that referenced this pull request Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants