Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sparse depth maps #1373

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

yimingzhou1
Copy link
Contributor

Background

In nerfstudio, the losses for depth don't support sparse depth maps.

Description

  1. Modified ds_nerf_depth_loss, urban_radiance_field_depth_loss in losses.py.

  2. Modified the way of computing depth_mse in eval.

  3. Fixed typo Depht -> Depth.

Verification

Train depth-nerfacto with the Replica Dataset using only two views with sparse depth supervision (randomly masking out 90% of the depth map). left: groundtruth sparse depth map. right: predicted dense depth map. Results below are generated using ds_nerf_depth_loss.

Screenshot 2023-02-07 at 2 05 44 PM

Screenshot 2023-02-07 at 2 06 34 PM

* sparse depth maps

* pr comments

* unified loss

* minor

* lint
Copy link
Contributor

@tancik tancik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding.

@tancik tancik merged commit 8c9c2ba into nerfstudio-project:main Feb 8, 2023
chris838 pushed a commit to chris838/nerfstudio that referenced this pull request Apr 22, 2023
Add support for sparse depth maps (nerfstudio-project#2)

* sparse depth maps

* pr comments

* unified loss

* minor

* lint
@aayushg55 aayushg55 mentioned this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants