Corrected the order of texture arguments #1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris838
pushed a commit
to chris838/nerfstudio
that referenced
this pull request
Apr 22, 2023
corrected the order of texture arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tancik Before this fix, using
scripts/texture.pyto texture an existing mesh will give an error:TypeError: unsupported operand type(s) for /.This is due to the inconsistent argument order when calling
texture_utils.export_textured_meshfromscripts/texture.py. The argumentsself.px_per_uv_triangleandself.output_dirshould be swapped.