Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create video writer later, to adapt to render image's width and height (fixes #1242) #1245

Merged
merged 3 commits into from
Jan 17, 2023
Merged

create video writer later, to adapt to render image's width and height (fixes #1242) #1245

merged 3 commits into from
Jan 17, 2023

Conversation

machenmusik
Copy link
Contributor

No description provided.

@machenmusik machenmusik mentioned this pull request Jan 17, 2023
Closed
tancik
tancik approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@tancik tancik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing

@tancik tancik merged commit f350650 into nerfstudio-project:main Jan 17, 2023
@machenmusik machenmusik deleted the render-late-image-size branch January 18, 2023 01:01
tancik pushed a commit to dozeri83/nerfstudio that referenced this pull request Jan 20, 2023
@machenmusik @tancik
create video writer later, to adapt to render image's width and height (
2a8ca0f 
fixes nerfstudio-project#1242) (nerfstudio-project#1245)

* create video writer later, to adapt to render image's width and height

* fix rendering with multiple output names
lucasthahn pushed a commit to tne-ai/nerfstudio that referenced this pull request Jan 26, 2023
@machenmusik @lucasthahn
create video writer later, to adapt to render image's width and height (
546e919 
fixes nerfstudio-project#1242) (nerfstudio-project#1245)

* create video writer later, to adapt to render image's width and height

* fix rendering with multiple output names
chris838 pushed a commit to chris838/nerfstudio that referenced this pull request Apr 22, 2023
@machenmusik
create video writer later, to adapt to render image's width and height (
bf310f3 
fixes nerfstudio-project#1242) (nerfstudio-project#1245)

* create video writer later, to adapt to render image's width and height

* fix rendering with multiple output names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tancik tancik tancik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@machenmusik @tancik