Blender addon script and documentation #1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First version of blender addon python script located in scripts/blender and new documentation for the addon. The Blender addon is for importing or exporting a camera path for visual effects and compositing.
Updated the formatting based on the script tests for the blender addon script.
Updated how FOV is calculated for both blender cam to json and json to blender cam. The FOV is calculated based on the aspect ratio, angle of view, and sensor fit and size.
Updated the Blender add-on documentation with a few example gif composite animations
tancik
reviewed
Jan 17, 2023
|
|
||
|
|
||
| # create a JSON camera path from the Blender camera animation | ||
| class CreateJSONCameraPath(bpy.types.Operator): |
There was a problem hiding this comment.
Can you add docstrings to this file in the same way that the rest of the repo does. In addition to types. I'm happy to walk through some of the typing if you have questions.
| @@ -0,0 +1,404 @@ | |||
| bl_info = { | |||
| "name": "Nerfstudio Add-On", | |||
There was a problem hiding this comment.
Add an empty file scripts/blender/__init__.py
This will cause the linter to parse it. Then run ns-dev-test, you will likely see many lint issues. These should be resolved, sometime they can be a bit tricky, feel free to let me know if you have questions.
Updated the Blender add-on script and docs to match the Blender frame rate. Also the formatting should be fixed. There are also now error message popups instead of console prints for invalid input in the add-on.
tancik
reviewed
Jan 19, 2023
| "category": "Nerfstudio", | ||
| } | ||
|
|
||
| import json | ||
| from math import atan, degrees, radians, tan | ||
| import json # pylint: disable=wrong-import-position |
There was a problem hiding this comment.
I think # pylint: disable=wrong-import-position can be added once at the top of the file
|
|
||
| return {"FINISHED"} | ||
|
|
||
|
|
||
| # --- Blender UI Panel --- # | ||
|
|
||
|
|
||
| class NerfstudioMainPanel(bpy.types.Panel): | ||
| class NerfstudioMainPanel(bpy.types.Panel): # pylint: disable=too-few-public-methods | ||
| """Blener UI main panel for the add-on.""" |
There was a problem hiding this comment.
Blener -> Blender
(Also in following functions)
Updated pylint formatting and comments
tancik
approved these changes
Jan 20, 2023
lucasthahn
pushed a commit
to tne-ai/nerfstudio
that referenced
this pull request
Jan 26, 2023
* Blender addon script and documentation First version of blender addon python script located in scripts/blender and new documentation for the addon. The Blender addon is for importing or exporting a camera path for visual effects and compositing. * Updated formatting of Blender script Updated the formatting based on the script tests for the blender addon script. * Updated Blender addon to fix FOV and alignment Updated how FOV is calculated for both blender cam to json and json to blender cam. The FOV is calculated based on the aspect ratio, angle of view, and sensor fit and size. * Updated Blender addon documentation with examples Updated the Blender add-on documentation with a few example gif composite animations * Updated Blender addon to match frame rate and fixed formatting Updated the Blender add-on script and docs to match the Blender frame rate. Also the formatting should be fixed. There are also now error message popups instead of console prints for invalid input in the add-on. * Updated the blender addon for formatting Updated pylint formatting and comments
chris838
pushed a commit
to chris838/nerfstudio
that referenced
this pull request
Apr 22, 2023
* Blender addon script and documentation First version of blender addon python script located in scripts/blender and new documentation for the addon. The Blender addon is for importing or exporting a camera path for visual effects and compositing. * Updated formatting of Blender script Updated the formatting based on the script tests for the blender addon script. * Updated Blender addon to fix FOV and alignment Updated how FOV is calculated for both blender cam to json and json to blender cam. The FOV is calculated based on the aspect ratio, angle of view, and sensor fit and size. * Updated Blender addon documentation with examples Updated the Blender add-on documentation with a few example gif composite animations * Updated Blender addon to match frame rate and fixed formatting Updated the Blender add-on script and docs to match the Blender frame rate. Also the formatting should be fixed. There are also now error message popups instead of console prints for invalid input in the add-on. * Updated the blender addon for formatting Updated pylint formatting and comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First version of blender addon python script located in scripts/blender and new documentation for the addon. The Blender addon is for importing or exporting a camera path for visual effects and compositing.