Skip to content

Add hashmap size and num_levels to instant_ngp_field, issue 1158 #1196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 1, 2023
Merged

Conversation

DreekFire
Copy link
Contributor

Added the new arguments to the end of the argument list because this would preserve compatibility with pre-existing code written using positional arguments. However, this argument order differs from that used in nerfacto.

Copy link
Contributor

@tancik tancik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DreekFire DreekFire merged commit 5710b09 into nerfstudio-project:main Jan 1, 2023
tancik pushed a commit to dozeri83/nerfstudio that referenced this pull request Jan 20, 2023
…fstudio-project#1196)

add hashmap size and num_levels to instant_ngp_field, issue 1158
lucasthahn pushed a commit to tne-ai/nerfstudio that referenced this pull request Jan 26, 2023
…fstudio-project#1196)

add hashmap size and num_levels to instant_ngp_field, issue 1158
chris838 pushed a commit to chris838/nerfstudio that referenced this pull request Apr 22, 2023
…fstudio-project#1196)

add hashmap size and num_levels to instant_ngp_field, issue 1158
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants