Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type and docs fixes #1170

Merged
merged 1 commit into from
Dec 26, 2022
Merged

Type and docs fixes #1170

merged 1 commit into from
Dec 26, 2022

Conversation

brentyi
Copy link
Collaborator

@brentyi brentyi commented Dec 26, 2022

No description provided.

@brentyi brentyi requested a review from tancik December 26, 2022 07:55
@brentyi brentyi mentioned this pull request Dec 26, 2022
Open
tancik
tancik approved these changes Dec 26, 2022
View reviewed changes
Copy link
Contributor

@tancik tancik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tancik tancik merged commit 5495a8e into main Dec 26, 2022
@tancik tancik deleted the brent/minor_type_and_docs branch December 26, 2022 16:04
tancik pushed a commit to dozeri83/nerfstudio that referenced this pull request Jan 20, 2023
@brentyi @tancik
Type and docs fixes (nerfstudio-project#1170)
62830da
chris838 pushed a commit to chris838/nerfstudio that referenced this pull request Apr 22, 2023
@brentyi
Type and docs fixes (nerfstudio-project#1170)
82acaa6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tancik tancik tancik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brentyi @tancik