when camera_type is equirectangular, add spherical metadata to rendered video #1151
Conversation
machenmusik
force-pushed
the
equirect-render-spherical-metadata
branch
from
eed5d40
to
8848729
Compare
machenmusik
force-pushed
the
equirect-render-spherical-metadata
branch
from
8848729
to
c4dade4
Compare
machenmusik
force-pushed
the
equirect-render-spherical-metadata
branch
from
4715e03
to
38325b8
Compare
Note: video render width and height were unspecified for spiral trajectory; this uses values for Nerfacto
|
It seemed inefficient for all rendered images to be held in memory just to encode video, so that is no longer done. As a curious side effect, I noticed that non-filename trajectories such as spiral don't have a defined render width or height. That didn't matter before when passing all the images at once to be encoded,, but it does now that we create the video writer before we have the first image (and its size). The values for Nerfacto are currently the default for spiral trajectory, but if there is a better way to know what resolution should be expected, that would be preferable. For later perhaps: it should be possible to reuse camera path files, but override the width and height for a given render command. (That might also help eliminate the ambiguity for non-filename trajectories.) |
machenmusik
force-pushed
the
equirect-render-spherical-metadata
branch
2 times, most recently
from
1eb9723
to
c6487f9
Compare
machenmusik
force-pushed
the
equirect-render-spherical-metadata
branch
from
c6487f9
to
963758c
Compare
|
(okay, finally got isort / black / pylint to agree...) |
|
Looks good, feel free to merge. You should now have access (check your email) |
|
Done thx |
…ed video (nerfstudio-project#1151) * when camera_type is equirectangular, add spherical metadata to rendered video * remove unnecessary CONSOLE.print * refactor to make pylint happier * get os.stat size properly; document camera_type argument * write video on the fly to avoid holding all images in memory Note: video render width and height were unspecified for spiral trajectory; this uses values for Nerfacto * fix images output * doc fix
…ed video (nerfstudio-project#1151) * when camera_type is equirectangular, add spherical metadata to rendered video * remove unnecessary CONSOLE.print * refactor to make pylint happier * get os.stat size properly; document camera_type argument * write video on the fly to avoid holding all images in memory Note: video render width and height were unspecified for spiral trajectory; this uses values for Nerfacto * fix images output * doc fix
Implements #1149.