Camera Label Hiding #1031
Merged
Camera Label Hiding #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just tried this here - https://viewer.nerf.studio/versions/branch/davidm-camera-name-hiding/ |
Oh I moved away from that branch and thought I deleted it lol. Here's the right one https://viewer.nerf.studio/versions/branch/davidm-viewier-camera-name-hiding/ |
|
Ahh gotcha. Is clicking the "hide scene" button at the top using different logic? |
Not sure, I could check. It seems to be working for me |
|
This is what I see |
Gotcha I can repro, I'll look into it |
|
Just added the hide scene logic @tancik |
tancik
pushed a commit
to dozeri83/nerfstudio
that referenced
this pull request
Jan 20, 2023
* ThreeJS group traversal * Isolated hiding to camera labels * Logic for hide scene addeD
chris838
pushed a commit
to chris838/nerfstudio
that referenced
this pull request
Apr 22, 2023
* ThreeJS group traversal * Isolated hiding to camera labels * Logic for hide scene addeD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #567. This is the least janky way I found to do this