Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for insta360 single-file format #1024

Merged
merged 7 commits into from
Nov 28, 2022
Merged

Add support for insta360 single-file format #1024

merged 7 commits into from
Nov 28, 2022

Conversation

cnsumner
Copy link
Contributor

@cnsumner cnsumner commented Nov 25, 2022

This adds support for the 2:1 aspect ratio single-file format used in some recording modes of Insta360 cameras (X3, normal video mode is confirmed, other modes unsure but possible).

Removed transpose from the ffmpeg command for fetching frames because I found it yielded better results.

I am not a python dev so please critique if I've made any horrible mistakes in this code!

Resolves #1019

Copy link
Contributor

@tancik tancik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delayed review (on holiday). I think the proposed solution in this PR works for now. I wrote some comments in #1019 for how we might better support these cameras in the future.

nerfstudio/process_data/insta360_utils.py Show resolved Hide resolved
@tancik tancik merged commit 3d70b4e into nerfstudio-project:main Nov 28, 2022
tancik added a commit to dozeri83/nerfstudio that referenced this pull request Jan 20, 2023
* Add support for insta360 single-file format

* Improve some variable names

* Add documentation for crop_percentage parameter

Co-authored-by: Matthew Tancik <[email protected]>
chris838 pushed a commit to chris838/nerfstudio that referenced this pull request Apr 22, 2023
* Add support for insta360 single-file format

* Improve some variable names

* Add documentation for crop_percentage parameter

Co-authored-by: Matthew Tancik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ns-process-data insta360 does not support the single-file format used by the insta360 X3
2 participants