Skip to content

Commit

Permalink
Ns-process-data bug with dev version of colmap (#2651)
Browse files Browse the repository at this point in the history
* only parse digit and decimal

* formatting
  • Loading branch information
AdamRashid96 authored Dec 7, 2023
1 parent 4c627ed commit 64f0b25
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion nerfstudio/process_data/colmap_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,9 @@ def get_colmap_version(colmap_cmd: str, default_version=3.8) -> float:
assert output is not None
for line in output.split("\n"):
if line.startswith("COLMAP"):
return float(line.split(" ")[1])
version = line.split(" ")[1]
version = "".join([c for c in version if c.isdigit() or c == "."])
return float(version)
CONSOLE.print(f"[bold red]Could not find COLMAP version. Using default {default_version}")
return default_version

Expand Down

0 comments on commit 64f0b25

Please sign in to comment.