Use windows's winusb driver #5

dioannidis · 2021-03-19T14:01:20Z

Add OS Descriptor support and report to windows ( ~~8.1 and up~~ ) that we are compatible with the winusb driverand use that. No need for zadig or libusb anymore.

EDIT: Forgot to mention, that this patch is based on the work done by Marius Greuel @mariusgreuel at repo USBasp. Because, the code, it was too intrusive for me, I modify it to work without the need to change the V-USB code at all.

…e are compatible with the winusb driver.

dioannidis · 2021-03-19T16:33:33Z

Hi,

in case after you flashed the firmware it doesn't work automatically, you must delete the device associated key in usbflags from the windows registry. Windows stores all the usb devices that answer or not the os string descriptor call. If the device doesn't answer the os string descriptor call, windows store that information in the registry and doesn't call again for that device "triplet" so it won't load the winusb driver. If the device answers, then it stores that it needs to call during enumeration, for feature descriptor associated with the MS_VENDOR_CODE.

The registry key is :

HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\usbflags<VVVVPPPPRRRR>
Where
vvvv is the vendor id
pppp is the product id
rrrr is the revision number of the device.

meaning that for usbasp 1.07 is :

Computer\HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\usbflags\16C005DC0107

nerdralph · 2021-03-20T19:09:10Z

Why is the OS String descriptor array 18 bytes long, but bLength is 20 (0x14)?
I think the code would be cleaner using a UTF-16 string initialization. i.e. u“MSFT100”.

dioannidis · 2021-03-20T20:31:04Z

Hi,

Why is the OS String descriptor array 18 bytes long, but bLength is 20 (0x14)?

Because this is what the caller requires.

"Version 1.00 of the OS string descriptor has a fixed length of 18 bytes, with a structure as shown in the following table. This format MUST be used by all OS string descriptors.

Length	Type	Signature	MS Vendor Code	Pad
0x14	0x03	MSFT100	unsigned byte	0x00

Length: An unsigned byte and MUST be set to 0x14.

Type: An unsigned byte and MUST be set to 0x03.

Signature: A Unicode string and MUST be set to "MSFT100".

MS Vendor Code: An unsigned byte, it will be used to retrieve associated feature descriptors.

Pad: An unsigned byte and MUST be set to 0x00."

See "3.3.5.3.9 Processing an OS Descriptor request" https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-rdpeusb/c2f351f9-84d2-4a1b-9fe3-a6ca195f84d0.

I think the code would be cleaner using a UTF-16 string initialization. i.e. u“MSFT100”.

Maybe you're right. I personally prefer it as an array in progmem because it's a simple array as stated in the "3.3.5.3.9 Processing an OS Descriptor request" document :

"•The Signature field contains a Unicode character array that identifies the descriptor as an OS string descriptor and includes the version number. For version 1.00, this array must be set to "MSFT100" (0x4D00 0x5300 0x4600 0x5400 0x3100 0x3000 0x3000)."

dioannidis · 2021-03-20T22:34:23Z

Hi,

I added some comments explaining in general the mechanism.

EDIT: As I re-read the "Microsoft OS Descriptors for USB Devices" I missed that this process is supported and in Windows 7, so you can test it on your windows box.

nerdralph · 2021-03-20T23:05:37Z

This link says 18 (0x12), which makes more sense: https://docs.microsoft.com/en-us/windows-hardware/drivers/network/mb-interface-model-supplement I can't test it anyway, so I probably won't merge it.

…

On Sat, Mar 20, 2021, 17:31 Dimitrios Chr. Ioannidis < ***@***.***> wrote: Hi, Why is the OS String descriptor array 18 bytes long, but bLength is 20 (0x14)? Because this is what the caller requires. "Version 1.00 of the OS string descriptor has a fixed length of 18 bytes, with a structure as shown in the following table. This format MUST be used by all OS string descriptors. Length Type Signature MS Vendor Code Pad 0x14 0x03 MSFT100 unsigned byte 0x00 Length: An unsigned byte and MUST be set to 0x14." See "3.3.5.3.9 Processing an OS Descriptor request" https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-rdpeusb/c2f351f9-84d2-4a1b-9fe3-a6ca195f84d0 . I think the code would be cleaner using a UTF-16 string initialization. i.e. u“MSFT100”. Maybe you're right. I personally prefer it as an array in progmem because it's a simple array as stated in the "3.3.5.3.9 Processing an OS Descriptor request" document : "•The Signature field contains a Unicode character array that identifies the descriptor as an OS string descriptor and includes the version number. For version 1.00, this array must be set to "MSFT100" (0x4D00 0x5300 0x4600 0x5400 0x3100 0x3000 0x3000)." — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#5 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABKNZ6RSE2Q3SEICA56YNN3TEUAZLANCNFSM4ZO3H45Q> .

…he link https://docs.microsoft.com/en-us/windows-hardware/drivers/network/mb-interface-model-supplement in his message nerdralph/usbasp#5 (comment)

dioannidis · 2021-03-20T23:17:39Z

Hi,

I can't test it anyway, so I probably won't merge it.

IMHO, you can test it on your windows 7 box but it's your call.

Plus typo.

…eople to test .

nerdralph · 2021-03-22T23:04:58Z

Hi,

I can't test it anyway, so I probably won't merge it.

IMHO, you can test it on your windows 7 box but it's your call.

The MS docs are inconsistent and even contradictory in places. I guess I'll give it a try and see. I'll bump the release number (bcdDevice) to ensure the cached libusb driver association isn't used.

nerdralph · 2021-03-22T23:41:36Z

@dioannidis, is there a reason why this is in RAM, and not flash?
https://github.com/dioannidis/usbasp/blob/master/firmware/main.c#L160

I was going to open an issue in your fork, but you don't seem to have it enabled.

nerdralph · 2021-03-23T00:24:28Z

I cloned your fork, turned on -Wextra, and found some warnings that I think should be cleaned up:

main.c:162:2: warning: missing initializer for field 'reserved' of 'usbExtCompatHeader_t' {aka 'struct <anonymous>'} [-Wmissing-field-initializers]
  { sizeof(usbExtCompatDescriptor_t), 0x0100, 0x0004, 1 },
  ^
main.c:147:10: note: 'reserved' declared here
  uint8_t reserved[7];
          ^~~~~~~~
main.c:167:1: warning: missing initializer for field 'reserved2' of 'usbExtCompatDescriptor_t' {aka 'const struct <anonymous>'} [-Wmissing-field-initializers]
 };
 ^
main.c:157:10: note: 'reserved2' declared here
  uint8_t reserved2[6];
          ^~~~~~~~~

dioannidis · 2021-03-23T00:46:38Z

Hi,

@dioannidis, is there a reason why this is in RAM, and not flash?
https://github.com/dioannidis/usbasp/blob/master/firmware/main.c#L160

For no specific reason except that I used Marius code . If you look at the code above typedef's you'll see a comment : "/* TODO: Change them to progmem consts */"

dioannidis · 2021-03-23T00:48:47Z

Hi,

< snip >

The MS docs are inconsistent and even contradictory in places. I guess I'll give it a try and see. I'll bump the release number (bcdDevice) to ensure the cached libusb driver association isn't used.

As I don't have a box or vm with windows 7 ( and didn't had the time to setup one ) I'm curious to see if it works as Microsoft claims .

…entioned in nerdralph/usbasp#5 (comment) . Rebuild the atmega8 firmware.

dioannidis · 2021-03-23T13:24:03Z

Hi,

@dioannidis, is there a reason why this is in RAM, and not flash?
https://github.com/dioannidis/usbasp/blob/master/firmware/main.c#L160

< snip >

For no specific reason except that I used Marius code . If you look at the code above typedef's you'll see a comment : "/* TODO: Change them to progmem consts */"

Moved to flash. Tested in Windows 10 64bit.

I don't think there is anything more to do. @nerdralph, If there is something I missed, I'll be happy to fix it.

regards,

nerdralph · 2021-03-23T13:44:36Z

I just finished testing, and I think it works. I'm not sure how to remove the .inf that associates 0x16C0/0x05DC with libusb, so I'm still seeing it associate with libusb even after I deleted the usbflags regkey. My reason for suspecting it is working is because Zadig shows it as having WCID.

p.s. I started writing the comment before your latest. Having all descriptors in flash is something I wanted because it gets the binary below 4096 bytes, which means it can work with a mega48.

Add OS Descriptor support and report to windows ( 8.1 and up ) that w…

0f475af

…e are compatible with the winusb driver.

dioannidis mentioned this pull request Mar 19, 2021

v-usb update from upstream #4

Merged

dioannidis added 2 commits March 21, 2021 00:37

Add comments.

35b7e8f

Misc and spelling.

a28012c

Changed the length of the OS String Descriptor after Ralph's posted t…

734d211

…he link https://docs.microsoft.com/en-us/windows-hardware/drivers/network/mb-interface-model-supplement in his message nerdralph/usbasp#5 (comment)

dioannidis added 4 commits March 21, 2021 02:00

Aknowledge the Marius Greuel's hard work.

74b43ae

More comments. Add notice regarding the deletion of device registry key.

1192c89

Plus typo.

Comment forgotten debug code ...

d599262

Upload main_winusb.hex firmware for atmega8 with winusb changes for p…

a1ed02f

…eople to test .

Fix warnings mentioned in nerdralph/usbasp#5 (comment)

42b96eb

Move the OS Extended Compat ID feature descriptor to flash from ram m…

a2ab97e

…entioned in nerdralph/usbasp#5 (comment) . Rebuild the atmega8 firmware.

nerdralph merged commit 3206fd4 into nerdralph:master Mar 23, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use windows's winusb driver #5

Use windows's winusb driver #5

dioannidis commented Mar 19, 2021 •

edited

Loading

dioannidis commented Mar 19, 2021 •

edited

Loading

nerdralph commented Mar 20, 2021 •

edited

Loading

dioannidis commented Mar 20, 2021 •

edited

Loading

dioannidis commented Mar 20, 2021 •

edited

Loading

nerdralph commented Mar 20, 2021 via email

dioannidis commented Mar 20, 2021

nerdralph commented Mar 22, 2021

nerdralph commented Mar 22, 2021

nerdralph commented Mar 23, 2021

dioannidis commented Mar 23, 2021

dioannidis commented Mar 23, 2021

dioannidis commented Mar 23, 2021

nerdralph commented Mar 23, 2021 •

edited

Loading

Use windows's winusb driver #5

Use windows's winusb driver #5

Conversation

dioannidis commented Mar 19, 2021 • edited Loading

dioannidis commented Mar 19, 2021 • edited Loading

nerdralph commented Mar 20, 2021 • edited Loading

dioannidis commented Mar 20, 2021 • edited Loading

dioannidis commented Mar 20, 2021 • edited Loading

nerdralph commented Mar 20, 2021 via email

dioannidis commented Mar 20, 2021

nerdralph commented Mar 22, 2021

nerdralph commented Mar 22, 2021

nerdralph commented Mar 23, 2021

dioannidis commented Mar 23, 2021

dioannidis commented Mar 23, 2021

dioannidis commented Mar 23, 2021

nerdralph commented Mar 23, 2021 • edited Loading

dioannidis commented Mar 19, 2021 •

edited

Loading

dioannidis commented Mar 19, 2021 •

edited

Loading

nerdralph commented Mar 20, 2021 •

edited

Loading

dioannidis commented Mar 20, 2021 •

edited

Loading

dioannidis commented Mar 20, 2021 •

edited

Loading

nerdralph commented Mar 23, 2021 •

edited

Loading