Add on load callback parameter #153
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added on load callback parameter. * Fixed tests * Add callback as an example
|
I'm not quite sure how to mock out the onLoad on the img for the jest tests. I will look into this later, unless someone else has a good idea and can contribute or point me in the right direction. This fix is very open ended, but it gives the calling component a lot of control over what can be done to make the UX a lot smoother. |
* Added on load callback parameter. * Fixed tests * Add callback as an example * Added test
|
This is what it looks like as is, with images that take a while to load. With a callback, it allows the parent component to handle the loading to make it smoother. Of course, this is up to the parent component on how this is implemented, but adding this functionality enables many possibilities. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a callback parameter which will be called when all images in the gallery have finished loading.
This can allow the parent component of Gallery to implement things such as spinners or other mechanisms for smoother transitions when the images are taking too long to load.