fix(editorconfig): only warn once on errors

[lewis6991]

This isn't in the spec, but is used here: https://github.com/LuaLS/lua-language-server/blob/6c934845ad891f2e279ed96ffb0a163994e3729b/.editorconfig#L23 and https://github.com/CppCXY/EmmyLuaCodeStyle/blob/e6f382c58c09e5dca481e55ba125b9fbbbeadc26/lua.template.editorconfig#L23

I assume this comes from something like vscode?

Ref: #21669

EDIT: changed to warn once instead

[gpanders]

Supporting off spec entries might not be the best path forward. However, I found the warning very intrusive whilst trying to browse a project.

I also do not feel good about supporting off-spec values, particularly this one which is just a no-op (it's equivalent to not setting the property at all. Why??)

I don't think it should be the job of our editorconfig plugin to validate .editorconfig files, so an error Is probably a bit much.

Either:

• warning, once only
• no disruptive message, but send to a log file somewhere.

I think validating the .editorconfig values is valuable to catch typos/common errors (is it indent_style or indent_type? space or spaces?), but agreed that an error is probably too aggressive. One-time warning sounds good to me.

[lewis6991]

I think validating the .editorconfig values is valuable to catch typos/common errors (is it indent_style or indent_type? space or spaces?),

Then ideally these diagnostics should be thrown when editing a .editorconfig file, not when browsing any file in the repo. Maybe this is another candidate for an in-process LSP(?), or something like our TS query linter. Anyway, that's out of scope here, I'll make this a warning once.

[gpanders]

I made a PR to LuaLS to drop the off-spec value LuaLS/lua-language-server#2287.

[gpanders]

Then ideally these diagnostics should be thrown when editing a .editorconfig file, not when browsing any file in the repo.

Interesting idea, I hadn't thought of that but seems reasonable.

[lewis6991]

Done. Improved the typing a bit in typical fashion.

[github-actions]

Successfully created backport PR for release-0.9:

• [Backport release-0.9] fix(editorconfig): only warn once on errors #24907